Rework iio_context_get_xml() #1133
Merged
+42
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfcollins
reviewed
Jan 25, 2024
| @@ -300,6 +301,7 @@ class ChannelType(Enum): | |||
| _iiolib = "iio" | |||
|
|
|||
| _lib = _cdll("libiio.so.1", use_errno=True, use_last_error=True) | |||
| _libc = _cdll(find_library("c")) | |||
There was a problem hiding this comment.
This will fail in Windows. Need to use something like ctypes.util.find_msvcrt
Probably need to fix the _cdll call above as well since that breaks Windows too.
There was a problem hiding this comment.
If Python bindings were broken on Windows before, and they are still broken on Windows after, then I'd argue it's not a problem of this commit and it can be fixed later in a subsequent PR. I'm kind of running against time here :)
Instead of returning a string allocated alongside the IIO context, it will now return a string allocated on the heap, that has to be freed with free() afterwards. The function can now also return errors. The advantage of this change is multiple: - IIO contexts now don't have a huge XML string allocated during their whole lifetime; - If the application does not call iio_context_get_xml(), then all the internal functions used to generate the XML string in the first place are dead code, and when building statically, can be garbage-collected. Signed-off-by: Paul Cercueil <[email protected]>
Emulate the v0.x behaviour of iio_context_get_xml() by allocating the XML string when the Libiio context is created; which means that the compatibility layer's iio_context_get_xml() is still a "pure" function. Signed-off-by: Paul Cercueil <[email protected]>
Now that iio_context_get_xml() returns a heap-allocated string, we need to de-allocate it with free() after use. Signed-off-by: Paul Cercueil <[email protected]>
pcercuei
force-pushed
the
pcercuei/iio_context_get_xml
branch
from
78e06b9 to
37f3bf8
Compare
mhennerich
approved these changes
Jan 30, 2024
tfcollins
approved these changes
Jan 30, 2024
Now that iio_context_get_xml() returns a heap-allocated string, we need to de-allocate it with free() after use. Signed-off-by: Paul Cercueil <[email protected]>
Now that iio_context_get_xml() returns a heap-allocated string, we need to de-allocate it with free() after use. Signed-off-by: Paul Cercueil <[email protected]>
Now that iio_context_get_xml() returns a heap-allocated string, we need to de-allocate it with free() after use. Signed-off-by: Paul Cercueil <[email protected]>
pcercuei
force-pushed
the
pcercuei/iio_context_get_xml
branch
from
37f3bf8 to
79ffd4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of returning a string allocated alongside the IIO context, it
will now return a string allocated on the heap, that has to be freed
with free() afterwards. The function can now also return errors.
The advantage of this change is multiple:
whole lifetime;
internal functions used to generate the XML string in the first place
are dead code, and when building statically, can be garbage-collected.
C# bindings will be updated by @AlexandraTrifan in #1122.